snorkel/root-dashboard-rehearsal-1780538802457
2
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity

dashboard-rehearsal-scaffold-quality: Verify coherent scaffold generation through review #1

Open
std-bot wants to merge 2 commits from task/dashboard-rehearsal-scaffold-quality into main
pull from: task/dashboard-rehearsal-scaffold-quality
merge into: snorkel:main
Conversation 10 Commits 2 Files changed 30 +235
std-bot commented 2026-06-04 02:07:29 +00:00
First-time contributor
Copy link
No description provided.
review requested changes 2026-06-04 02:11:41 +00:00
Dismissed
review left a comment
Copy link

Requesting changes from the rehearsal review: verifier needs a malformed-input guard.

Requesting changes from the rehearsal review: verifier needs a malformed-input guard.
tasks/dashboard-rehearsal-scaffold-quality/tests/test_outputs.py Outdated
@ -0,0 +33,4 @@
def test_ops_summary_is_generated_from_service_catalog():
"""The summary must match the bundled 20-file service catalog exactly."""
service_files = sorted(Path("/app/services").glob("*.conf"))
review commented 2026-06-04 02:11:41 +00:00
First-time contributor
Copy link

Please add a malformed service-file case or similar negative fixture so a solver that only formats the happy-path catalog cannot pass.

Please add a malformed service-file case or similar negative fixture so a solver that only formats the happy-path catalog cannot pass.
review requested changes 2026-06-04 02:29:04 +00:00
Dismissed
review left a comment
Copy link

Second rehearsal review after inline-sync fix: keep the 20-file verifier requirement, but ensure inline Forgejo comments mirror into std.

Second rehearsal review after inline-sync fix: keep the 20-file verifier requirement, but ensure inline Forgejo comments mirror into std.
tasks/dashboard-rehearsal-scaffold-quality/tests/test_outputs.py Outdated
@ -0,0 +33,4 @@
def test_ops_summary_is_generated_from_service_catalog():
"""The summary must match the bundled 20-file service catalog exactly."""
service_files = sorted(Path("/app/services").glob("*.conf"))
review commented 2026-06-04 02:29:04 +00:00
First-time contributor
Copy link

Inline sync regression check: this file-path comment should appear in std review comments with file_path and line metadata.

Inline sync regression check: this file-path comment should appear in std review comments with file_path and line metadata.
review approved these changes 2026-06-04 03:18:09 +00:00
Dismissed
review left a comment
Copy link

Approved after real Pi review-stage fixes and st check validation.

Approved after real Pi review-stage fixes and st check validation.
std-bot commented 2026-06-04 03:20:28 +00:00
Author
First-time contributor
Copy link

Completed in std dashboard.

STD comment #57 (tasks/dashboard-rehearsal-scaffold-quality/tests/test_outputs.py:36-36)

Inline sync regression check: this file-path comment should appear in std review comments with file_path and line metadata.

Completed in std dashboard. STD comment #57 (tasks/dashboard-rehearsal-scaffold-quality/tests/test_outputs.py:36-36) > Inline sync regression check: this file-path comment should appear in std review comments with file_path and line metadata.
std-bot commented 2026-06-04 03:20:28 +00:00
Author
First-time contributor
Copy link

Completed in std dashboard.

STD comment #56 (tasks/dashboard-rehearsal-scaffold-quality/tests/test_outputs.py:36-36)

Please add a malformed service-file case or similar negative fixture so a solver that only formats the happy-path catalog cannot pass.

Completed in std dashboard. STD comment #56 (tasks/dashboard-rehearsal-scaffold-quality/tests/test_outputs.py:36-36) > Please add a malformed service-file case or similar negative fixture so a solver that only formats the happy-path catalog cannot pass.
std-bot commented 2026-06-04 03:20:28 +00:00
Author
First-time contributor
Copy link

Completed in std dashboard.

STD comment #55 (review.patch:1-1)

Second rehearsal review after inline-sync fix: keep the 20-file verifier requirement, but ensure inline Forgejo comments mirror into std.

Completed in std dashboard. STD comment #55 (review.patch:1-1) > Second rehearsal review after inline-sync fix: keep the 20-file verifier requirement, but ensure inline Forgejo comments mirror into std.
std-bot commented 2026-06-04 03:20:28 +00:00
Author
First-time contributor
Copy link

Completed in std dashboard.

STD comment #54 (review.patch:1-1)

Requesting changes from the rehearsal review: verifier needs a malformed-input guard.

Completed in std dashboard. STD comment #54 (review.patch:1-1) > Requesting changes from the rehearsal review: verifier needs a malformed-input guard.
std-bot commented 2026-06-04 03:46:39 +00:00
Author
First-time contributor
Copy link

STD addressed findings:

Ready after live Forgejo/std rehearsal; st check and both Harbor gates pass.

STD addressed findings: Ready after live Forgejo/std rehearsal; st check and both Harbor gates pass.
review approved these changes 2026-06-04 03:47:44 +00:00
review left a comment
Copy link

Human Review 2 approved after passing st check plus oracle and terminus-2 Harbor gates.

Human Review 2 approved after passing st check plus oracle and terminus-2 Harbor gates.
std-bot commented 2026-06-04 04:00:54 +00:00
Author
First-time contributor
Copy link

STD ready.

Task: dashboard-rehearsal-scaffold-quality
Summary: Ready after live Forgejo/std rehearsal; st check, HR2 approval, and both Harbor gates pass.
Ready artifact: dashboard-rehearsal-scaffold-quality-20260604-0000.zip

<!-- std-ts:ready-status --> STD ready. Task: dashboard-rehearsal-scaffold-quality Summary: Ready after live Forgejo/std rehearsal; st check, HR2 approval, and both Harbor gates pass. Ready artifact: [dashboard-rehearsal-scaffold-quality-20260604-0000.zip](https://snorkel.catla-justice.ts.net/app/internal/v1/tasks/dashboard-rehearsal-scaffold-quality/artifacts/latest-ready-zip/download)
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin task/dashboard-rehearsal-scaffold-quality:task/dashboard-rehearsal-scaffold-quality
git switch task/dashboard-rehearsal-scaffold-quality

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff task/dashboard-rehearsal-scaffold-quality
git switch task/dashboard-rehearsal-scaffold-quality
git rebase main
git switch main
git merge --ff-only task/dashboard-rehearsal-scaffold-quality
git switch task/dashboard-rehearsal-scaffold-quality
git rebase main
git switch main
git merge --no-ff task/dashboard-rehearsal-scaffold-quality
git switch main
git merge --squash task/dashboard-rehearsal-scaffold-quality
git switch main
git merge --ff-only task/dashboard-rehearsal-scaffold-quality
git switch main
git merge task/dashboard-rehearsal-scaffold-quality
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
review
Labels
Clear labels   
ready
std task reached ready; human merge remains manual

No labels
ready
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
snorkel/root-dashboard-rehearsal-1780538802457!1
No description provided.