dashboard-export-normalizer-rehearsal: Normalize dashboard export records #1
review
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "task/dashboard-export-normalizer-rehearsal"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Human Review 1: request changes. The generated benchmark has the right 20-service shape, but the verifier should explicitly assert the service fixture count so this cannot regress into a tiny/minimal codebase while still passing behavior checks.
@ -0,0 +66,4 @@def test_text_summary_contains_counts_and_projects():txt = Path("/app/normalized.txt").read_text(encoding="utf-8")assert "projects=2" in txtassert "proj-A" in txtdeployed resolve proof 20260604T154537Z: dashboard projection should reply inline and resolve this review conversation.
Resolved from std dashboard.
Resolved from std dashboard deployed proof for Forgejo comment 336.
@ -0,0 +67,4 @@txt = Path("/app/normalized.txt").read_text(encoding="utf-8")assert "projects=2" in txtassert "proj-A" in txtassert "proj-B" in txtPlease add an explicit verifier assertion that the bundled service fixture contains at least 20 service definition files. The task shape is good, but this needs to be protected directly.
Resolved from std dashboard.
Resolved from std dashboard live verification after projection-key fix.
Live projection proof: dashboard should reply here and resolve this Forgejo conversation.
Resolved from std dashboard.
Resolved from std dashboard live proof for Forgejo comment 334.
Human Review 1 still needs one concrete verifier hardening change: add an explicit assertion that the bundled fixture contains at least 20 service definition files. This should live in task/tests/test_outputs.py and should not count .gitignore files.
@ -0,0 +67,4 @@txt = Path("/app/normalized.txt").read_text(encoding="utf-8")assert "projects=2" in txtassert "proj-A" in txtassert "proj-B" in txtAdd an explicit verifier assertion here that counts /app/services/*.conf and requires at least 20 service definition files. Do not count .gitignore or unrelated files.
Like you should comment here and resolve it.
Human Review 1 approved. The verifier now explicitly checks the bundled service fixture has at least 20 .conf service definition files and excludes .gitignore/unrelated files.
Resolved in std dashboard.
STD comment #61 (tasks/dashboard-export-normalizer-rehearsal/task/tests/test_outputs.py:70-70)
Resolved in std dashboard.
STD comment #60 (review.patch:1-1)
Resolved in std dashboard.
STD comment #59 (tasks/dashboard-export-normalizer-rehearsal/task/tests/test_outputs.py:70-70)
Resolved in std dashboard.
STD comment #58 (review.patch:1-1)
STD pre-review findings:
Pre-review completed with no blocking findings.
Pre-review completed. Oracle and terminus-2 Harbor gates passed; st check passes; no open blocking review comments remain.
Human Review 2 approved. Final review accepts the verifier hardening, passing Harbor gates, and ready artifact path.
STD addressed findings:
Ready after HR2 approval. Ready artifact should be created from the checked task package.
Human Review 2 approved again after the corrected HR2 gate was requested. Ready is approved.
STD ready.
Task: dashboard-export-normalizer-rehearsal
Summary: Ready after accepted HR2 gate 36. Ready artifact should be created from the checked task package.
Ready artifact: dashboard-export-normalizer-rehearsal-20260604-0240.zip
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.Merge
Merge the changes and update on Forgejo.Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.