snorkel/root-repository-maintenance-4a9d6ef2d06f43
2
0
Fork 0
Code Issues Pull requests 5 Projects Releases Packages Wiki Activity

pin-node-type-surface: Pin Node ambient type surface #4

Open
std-bot wants to merge 1 commit from task/pin-node-type-surface into main
pull from: task/pin-node-type-surface
merge into: snorkel:main
Conversation 1 Commits 1 Files changed 167 +33727 -167
std-bot commented 2026-06-07 17:45:03 +00:00
First-time contributor
Copy link

Assigned idea

Make the TypeScript Node ambient type dependency explicit and version-stable for the checked JavaScript tooling files covered by the repository tsconfig.

Approach: Audit the package metadata for the dependency that satisfies tsconfig.json's types: ["node"], add or tighten the explicit @types/node devDependency if it is missing or floating, and keep the change limited to TypeScript configuration/package metadata so runtime code is unaffected.

Verification: Run pnpm install --frozen-lockfile and pnpm exec tsc -p tsconfig.json to confirm the scripts, *.config.*, and vitest.workspace.js files still typecheck with the pinned Node types.

Risk: Low; the change only affects development-time ambient types, though a stricter Node type version may reveal existing type errors in checked JS tooling files.

Agent context

Task slug: pin-node-type-surface
Branch: task/pin-node-type-surface

## Assigned idea Make the TypeScript Node ambient type dependency explicit and version-stable for the checked JavaScript tooling files covered by the repository tsconfig. Approach: Audit the package metadata for the dependency that satisfies tsconfig.json's `types: ["node"]`, add or tighten the explicit `@types/node` devDependency if it is missing or floating, and keep the change limited to TypeScript configuration/package metadata so runtime code is unaffected. Verification: Run `pnpm install --frozen-lockfile` and `pnpm exec tsc -p tsconfig.json` to confirm the `scripts`, `*.config.*`, and `vitest.workspace.js` files still typecheck with the pinned Node types. Risk: Low; the change only affects development-time ambient types, though a stricter Node type version may reveal existing type errors in checked JS tooling files. ## Agent context Task slug: pin-node-type-surface Branch: task/pin-node-type-surface <!-- std-ts:idea-pr-body -->
zero commented 2026-06-07 18:04:40 +00:00
Owner
Copy link

LGTM

LGTM
👍 1
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin task/pin-node-type-surface:task/pin-node-type-surface
git switch task/pin-node-type-surface

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff task/pin-node-type-surface
git switch task/pin-node-type-surface
git rebase main
git switch main
git merge --ff-only task/pin-node-type-surface
git switch task/pin-node-type-surface
git rebase main
git switch main
git merge --no-ff task/pin-node-type-surface
git switch main
git merge --squash task/pin-node-type-surface
git switch main
git merge --ff-only task/pin-node-type-surface
git switch main
git merge task/pin-node-type-surface
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
snorkel/root-repository-maintenance-4a9d6ef2d06f43!4
No description provided.