exact-reactor-vitest-aliases: Exact Reactor Vitest aliases #5

Open
std-bot wants to merge 2 commits from task/exact-reactor-vitest-aliases into main
First-time contributor

Assigned idea

Benchmark authoring specification.

Summary: Harden OpenProse’s root Vitest config so @openprose/reactor aliases resolve exact public subpaths without depending on alias order.

Task intent: Make the upstream root Vitest configuration resilient to alias reordering by changing the @openprose/reactor test aliases to exact matches while preserving their current dist replacements and offline live-test exclusion.

Benchmark plan: Construct the task package from openprose/prose at the fixed commit. The solver-facing prompt should ask for an upstream config hardening change in vitest.config.ts: exact-match the six public @openprose/reactor aliases used by conformance and ledger-replay tests, keep replacements pointed at packages/reactor/dist via reactorDist, and keep live tests excluded. Do not add unrelated feature work.

Environment plan: Task environment: Node and pnpm workspace from the repo root, no live model credentials, no network-dependent live tests. Repo environment: build packages first because vitest.config.ts aliases tests to packages/reactor/dist; use pnpm build before running Vitest conformance or example tests.

Verifier plan: test_outputs.py should inspect vitest.config.ts and expect the six @openprose/reactor alias find entries to be exact anchored RegExp matchers or an equivalent exact-only matcher, not plain prefix-prone string aliases. It should verify replacements still use reactorDist for the same dist files, verify .live.test.ts exclusion remains, and run pnpm build followed by pnpm vitest --config vitest.config.ts run "tests/open-prose/examples/**/.test.ts".

Oracle plan: The oracle patch edits vitest.config.ts only: replace each string find value for @openprose/reactor, @openprose/reactor/agents, @openprose/reactor/adapters, @openprose/reactor/run, @openprose/reactor/run/types, and @openprose/reactor/internals with an anchored exact RegExp while leaving replacement paths unchanged; update the nearby comment so it no longer says correctness depends on ordering.

Difficulty plan: Current coding systems may miss Vite/Rollup alias prefix semantics, simply reorder entries, or remove the dist aliasing that ledger replay depends on. They may also run Vitest without pnpm build or accidentally include live tests, so the hidden checks need both source inspection and repo commands.

Repo patch scope: Expected upstream edit scope is vitest.config.ts only. Do not modify packages/reactor/dist, package manifests, or tests/open-prose fixtures.

Anti-leakage notes: Do not expose benchmark, harness, Snorkel, Harbor, std-ts, agent, stage, attempt, retry, generated task, or evaluation context to the solver-facing prompt or files.

Approach: Use exact anchored matchers for the existing alias keys and preserve reactorDist replacements. Keep the alias array minimal and keep the hermetic offline test exclusion intact.

Verification: Verify with source checks on vitest.config.ts plus pnpm build and pnpm vitest --config vitest.config.ts run "tests/open-prose/examples/**/*.test.ts".

Risk: Static checks could be too implementation-specific if a solver uses a helper for exact matching; allow equivalent exact-only matchers while still rejecting plain string aliases for the reactor package names.

Path rules: task package is tasks/; mutable upstream checkout is tasks//environment/repo; benchmark package files are under tasks//task; verifier/container environment belongs under tasks//task/environment; regular and UI verifier logic belongs in task/tests/test_outputs.py and test.sh only runs that file through pytest.

Agent context

Task slug: exact-reactor-vitest-aliases
Branch: task/exact-reactor-vitest-aliases

## Assigned idea Benchmark authoring specification. Summary: Harden OpenProse’s root Vitest config so @openprose/reactor aliases resolve exact public subpaths without depending on alias order. Task intent: Make the upstream root Vitest configuration resilient to alias reordering by changing the @openprose/reactor test aliases to exact matches while preserving their current dist replacements and offline live-test exclusion. Benchmark plan: Construct the task package from openprose/prose at the fixed commit. The solver-facing prompt should ask for an upstream config hardening change in vitest.config.ts: exact-match the six public @openprose/reactor aliases used by conformance and ledger-replay tests, keep replacements pointed at packages/reactor/dist via reactorDist, and keep live tests excluded. Do not add unrelated feature work. Environment plan: Task environment: Node and pnpm workspace from the repo root, no live model credentials, no network-dependent live tests. Repo environment: build packages first because vitest.config.ts aliases tests to packages/reactor/dist; use pnpm build before running Vitest conformance or example tests. Verifier plan: test_outputs.py should inspect vitest.config.ts and expect the six @openprose/reactor alias find entries to be exact anchored RegExp matchers or an equivalent exact-only matcher, not plain prefix-prone string aliases. It should verify replacements still use reactorDist for the same dist files, verify *.live.test.ts exclusion remains, and run pnpm build followed by pnpm vitest --config vitest.config.ts run "tests/open-prose/examples/**/*.test.ts". Oracle plan: The oracle patch edits vitest.config.ts only: replace each string find value for @openprose/reactor, @openprose/reactor/agents, @openprose/reactor/adapters, @openprose/reactor/run, @openprose/reactor/run/types, and @openprose/reactor/internals with an anchored exact RegExp while leaving replacement paths unchanged; update the nearby comment so it no longer says correctness depends on ordering. Difficulty plan: Current coding systems may miss Vite/Rollup alias prefix semantics, simply reorder entries, or remove the dist aliasing that ledger replay depends on. They may also run Vitest without pnpm build or accidentally include live tests, so the hidden checks need both source inspection and repo commands. Repo patch scope: Expected upstream edit scope is vitest.config.ts only. Do not modify packages/reactor/dist, package manifests, or tests/open-prose fixtures. Anti-leakage notes: Do not expose benchmark, harness, Snorkel, Harbor, std-ts, agent, stage, attempt, retry, generated task, or evaluation context to the solver-facing prompt or files. Approach: Use exact anchored matchers for the existing alias keys and preserve reactorDist replacements. Keep the alias array minimal and keep the hermetic offline test exclusion intact. Verification: Verify with source checks on vitest.config.ts plus pnpm build and pnpm vitest --config vitest.config.ts run "tests/open-prose/examples/**/*.test.ts". Risk: Static checks could be too implementation-specific if a solver uses a helper for exact matching; allow equivalent exact-only matchers while still rejecting plain string aliases for the reactor package names. Path rules: task package is tasks/<slug>; mutable upstream checkout is tasks/<slug>/environment/repo; benchmark package files are under tasks/<slug>/task; verifier/container environment belongs under tasks/<slug>/task/environment; regular and UI verifier logic belongs in task/tests/test_outputs.py and test.sh only runs that file through pytest. ## Agent context Task slug: exact-reactor-vitest-aliases Branch: task/exact-reactor-vitest-aliases <!-- std-ts:idea-pr-body -->
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin task/exact-reactor-vitest-aliases:task/exact-reactor-vitest-aliases
git switch task/exact-reactor-vitest-aliases

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff task/exact-reactor-vitest-aliases
git switch task/exact-reactor-vitest-aliases
git rebase main
git switch main
git merge --ff-only task/exact-reactor-vitest-aliases
git switch task/exact-reactor-vitest-aliases
git rebase main
git switch main
git merge --no-ff task/exact-reactor-vitest-aliases
git switch main
git merge --squash task/exact-reactor-vitest-aliases
git switch main
git merge --ff-only task/exact-reactor-vitest-aliases
git switch main
git merge task/exact-reactor-vitest-aliases
git push origin main
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
snorkel/root-repository-maintenance-e12f3c587c0145!5
No description provided.